Merged
Conversation
* Allow sharing DomainParticipant with C++ applications * Add comment about UserObjectQosPolicy * Resolve uncrustify errors Signed-off-by: Andrea Sorbini <asorbini@rti.com>
asorbini
added
galactic-backports
Member
|
Collaborator
Author
|
Running full CI to validate changes again, and hopefully get this PR in the next Galactic patch:
@ivanpauno @hidmic review ping since you originally reviewed #25 |
Collaborator
Author
|
Also ping @clalancette since you participated in the discussion for #25. |
ivanpauno
approved these changes
Oct 21, 2021
Collaborator
Author
|
@ivanpauno thank you for the review! Can I go ahead and merge the PR with one approval (since we're out of code freeze) or do "backports" need more than one? |
Member
|
Merging with one approval is fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports changes from #25 to branch galactic so that they may be included in the next galactic patch release.